RRD metrics: "runnable_any" and "runnable_vcpus" #6615
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Please squash some of the commits to include fixes and right metric names in the initial commit introducing them |
gangj
force-pushed
the
private/gangj/CP-308857
branch
from
32c1fd5 to
ec0b510
Compare
|
We need to wait for the new release of xen containing the new(Runstateinfo.V2) API for both XS8 and XS9 to merge and release the changes in xapi. |
|
The first commit has some changes that don't belong there c2663f2, that should probably be moved to a commit of its own (cleaning up vcpu vs VCPU vs vCPU naming). Overall the diff looks OK though, just small change to how the commits are structured. |
|
You really need to delete the names RRD1 and RRD2 from the commit messages. They're internal codenames, and will specifically be meaningless to people in public. |
"vcpu", "VCPU" unified to "vCPU". Signed-off-by: Gang Ji <[email protected]>
Adding a new metric 'runnable_any' as % of time that at least one vCPU of the domain is in the runnable state. It is the sum of the following 3 metrics: - runstate_full_contention - runstate_concurrency_hazard - runstate_partial_contention Naming it 'runnable_any' instead of 'runnable' is to resolve one problem with rrd2csv: if we name it 'runnable', rrd2csv will select both "runnable" and "runnable_vcpus" when the 'runnable' is used: > rrd2csv AVERAGE:vm:<vm-uuid>:runnable > timestamp, AVERAGE:vm:<vm-uuid>:runnable, AVERAGE:vm:<vm-uuid>:runnable_vcpus This is because "runnable" is a prefix of "runnable_vcpus". Naming it 'runnable_any', with rrd2csv: * can select only 'runnable_any' if we use: rrd2csv AVERAGE:vm:<vm-uuid>:runnable_any * can select only 'runnable_vcpus' if we use: rrd2csv AVERAGE:vm:<vm-uuid>:runnable_vcpus * can select both 'runnable_any' and 'runnable_vcpus' if we use: rrd2csv AVERAGE:vm:<vm-uuid>:runnable Naming it 'runnable_any' also makes it clearer as the metric is % of time that at least one vCPU of the domain is in the runnable state. Add max to "runnable_any" metric to follow the fix here: Signed-off-by: Bengang Yuan <[email protected]> [Rebase with metric renaming and some fixes] Signed-off-by: Gang Ji <[email protected]>
Adding a new CPU ready RRD metric: "runnable_vcpus" per domain as time % of vCPUs of the domain that are in the runnable state. Signed-off-by: Gang Ji <[email protected]>
Query runstate with the new API: Xenctrl.Runstateinfo.V2.domain_get Signed-off-by: Marcus Granado <[email protected]>
gangj
force-pushed
the
private/gangj/CP-308857
branch
from
ec0b510 to
d355725
Compare
gangj
changed the title
edwintorok
approved these changes
Aug 6, 2025
mg12
approved these changes
Aug 6, 2025
6 tasks
6 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Squashed the history in PR #6612 together with the history in feature/vcpu-runnable.