Skip to content

Conversation

gangj
Copy link
Contributor

@gangj gangj commented Jul 10, 2025

It is because the known issue is only with non-management VLAN:

https://docs.xenserver.com/en-us/xenserver/8/storage/format#thin-provisioned-shared-gfs2-block-storage

We recommend not to use a GFS2 SR with a VLAN due to a known issue where you cannot add or remove hosts on a clustered pool if the cluster network is on a non-management VLAN.

@gangj gangj requested review from edwintorok and lindig and removed request for lindig July 10, 2025 14:23
@MarkSymsCtx
Copy link
Contributor

What stops fixing the general case here so that VLANs can be used? This would seem to be a generally beneficial improvement for customers?

@edwintorok
Copy link
Contributor

edwintorok commented Jul 10, 2025

What stops fixing the general case here so that VLANs can be used? This would seem to be a generally beneficial improvement for customers?

I think XAPI doesn't copy VLAN settings when joining a pool for anything except the management network.
That might be fixable, although in the end it won't gain you much: if the 2 VLANs end up sharing the same physical network then you have no benefit from separating the 2 networks: if one of the VLANs floods the interface, the other one might experience delays anyway, I don't think we do anything clever wrt to QoS between VLANs.

And if the VLANs would be on separate NICs, then you could just make the clustering network a non-VLAN network: the only hosts needing access to that are the clustering hosts, and those also have access to the non-vlan port already.

The management interface is different because that one needs to be accessed by external hosts (XC), which may only be able to reach it on the VLAN.

with
| vlan, false when vlan > 0L ->
error
"Cannot join pool whose clustering is enabled on non-management \
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

would use "… is enabled on a non-management VLAN network"

It is because the known issue is only with non-management VLAN:

https://docs.xenserver.com/en-us/xenserver/8/storage/format#thin-provisioned-shared-gfs2-block-storage

We recommend not to use a GFS2 SR with a VLAN due to a known issue where
you cannot add or remove hosts on a clustered pool if the cluster
network is on a non-management VLAN.

Signed-off-by: Gang Ji <[email protected]>
@gangj gangj force-pushed the private/gangj/XSI-1952 branch from 2ad16db to d958124 Compare July 10, 2025 14:35
@gangj gangj added this pull request to the merge queue Jul 10, 2025
Merged via the queue into xapi-project:master with commit a182d52 Jul 10, 2025
16 checks passed
@BengangY BengangY changed the title XSI-1954: Only block pool join for clustering on non-management VLAN CA-413598/XSI-1954: Only block pool join for clustering on non-management VLAN Jul 11, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants