xapi-stdext-threads: calibrate ratio for delay times #6568
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
last-genius
approved these changes
Jul 3, 2025
ocaml/libs/xapi-stdext/lib/xapi-stdext-threads/scheduler_test.ml
Outdated
Show resolved
Hide resolved
last-genius
reviewed
Jul 4, 2025
ocaml/libs/xapi-stdext/lib/xapi-stdext-threads/scheduler_test.ml
Outdated
Show resolved
Hide resolved
changlei-li
reviewed
Jul 7, 2025
On very busy systems, the wait may take much longer than expected. Instead of hard-coding the expected value, wait once to estimate the time aded to the delays, and then use it to compare the times. Also change to use Mtime.Spans instead of using integers. Signed-off-by: Pau Ruiz Safont <[email protected]>
changlei-li
approved these changes
Jul 7, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
On very busy systems, the wait may take much longer than expected. Instead of hard-coding the expected value, wait once to estimate the time aded to the delays, and then use it to compare the times.
Also change to use Mtime.Spans instead of using integers.
I've tested this locally on unit-tests, and @ydirson has tested this on his system that usually needs a patch to disable these tests because they run on an cpu-overprovisioned xen system