Skip to content

Conversation

liulinC
Copy link
Collaborator

@liulinC liulinC commented Jun 11, 2025

from https://en.wikipedia.org/wiki/Passwd#Password_file uid_info as following format

username:password:uid:gid:gecos:homedir:shell

Regarding gecos, it is recommended as follows

Typically, this is a set of comma-separated values including the user's full name and contact details.

However, this information comes form AD and user may mis-configure it with :, which is used as seperator. In such case, the parse would failed.

Enhance the parse function to support : in gecos, other fields does not likely contain it.

Copy link
Contributor

@last-genius last-genius left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please correct the commit title to specify that "uid-info does not support : in gecos" specifically, not in general

Copy link
Contributor

@lindig lindig left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pragmatic solution.

@liulinC liulinC force-pushed the private/linl/xsi-1901 branch from d495f41 to 7426ffe Compare June 12, 2025 08:52
from https://en.wikipedia.org/wiki/Passwd#Password_file
uid_info as following format

username:password:uid:gid:gecos:homedir:shell

Regarding gecos, it is recommended as follows

Typically, this is a set of comma-separated values including the user's
full name and contact details.

However, this information comes form AD and user may mis-configure
it with `:`, which is used as seperator. In such case, the parse
would failed.

Enhance the parse function to support `:` in gecos, other fields does
not likely contain it.

Signed-off-by: Lin Liu <[email protected]>
@liulinC liulinC force-pushed the private/linl/xsi-1901 branch from 7426ffe to 6fe7c9e Compare June 12, 2025 08:54
@liulinC liulinC added this pull request to the merge queue Jun 12, 2025
Merged via the queue into xapi-project:master with commit af0769d Jun 12, 2025
16 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants