Skip to content

Conversation

@edwintorok
Copy link
Contributor

Also fix the Makefile, so that 'make clean' also deletes the .o.d files.

This avoids accidentally adding these files to git (although normally dune would invoke make in _build,
only if you manually invoke it would it create these extra files):

A ocaml/forkexecd/helper/close_from.o
A ocaml/forkexecd/helper/close_from.o.d
A ocaml/forkexecd/helper/syslog.o
A ocaml/forkexecd/helper/syslog.o.d
A ocaml/forkexecd/helper/vfork_helper
A ocaml/forkexecd/helper/vfork_helper.o
A ocaml/forkexecd/helper/vfork_helper.o.d

Also fix the Makefile, so that 'make clean' also deletes the `.o.d` files.

This avoids accidentally adding these files to git
(although normally dune would invoke make in _build,
 only if you manually invoke it would it create these extra files):
```
A ocaml/forkexecd/helper/close_from.o
A ocaml/forkexecd/helper/close_from.o.d
A ocaml/forkexecd/helper/syslog.o
A ocaml/forkexecd/helper/syslog.o.d
A ocaml/forkexecd/helper/vfork_helper
A ocaml/forkexecd/helper/vfork_helper.o
A ocaml/forkexecd/helper/vfork_helper.o.d
```

Signed-off-by: Edwin Török <[email protected]>
@edwintorok edwintorok enabled auto-merge June 10, 2025 14:32
@freddy77 freddy77 requested review from andyhhp and lindig June 10, 2025 14:54
@edwintorok edwintorok added this pull request to the merge queue Jun 10, 2025
Merged via the queue into xapi-project:master with commit e67f151 Jun 10, 2025
16 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants