Parallelize host evacuation even more #6514
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
With bab83d9, host evacuation was parallelized by grouping VMs
into batches, and starting a new batch once the previous one has finished.
This means that a single slow VM can potentially slow down the whole evacuation.
Add a new
Tasks.wait_for_all_with_callbackfunction that willinvoke a callback every time one of the tasks is
deemed non-pending. This will allow its users to:
Use the new
Tasks.wait_for_all_with_callbackinxapi_hosttoschedule a new migration as soon as any of the previous ones have
finished, thus maintaining a constant flow of
nmigrations.Additionally expose the
evacuate-batch-sizeparameter in the CLI, thiswas missed when it was originally added with the CLI setting it to
0(pick the default) all the time.
===
Manually tested multiple times, confirmed to not break anything and to actually maintain a constant flow of migrations. This should greatly speed up host evacuations when there is a combination of bigger and smaller VMs (in terms of memory/disk, or VMs with some other reason for slow migration) on the host