CA-408492: Add back receive_finalize2 as well
#6465
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Similar to receive_start2, we need to keep receive_finalize2 as well for backwards compatibility Signed-off-by: Vincent Liu <[email protected]>
Vincent-lau
force-pushed
the
private/shul2/receive_start3
branch
from
2f01f43 to
96f8ba9
Compare
Similar to receive_start2 Signed-off-by: Vincent Liu <[email protected]>
psafont
reviewed
May 13, 2025
|
|
||
| (** Called on the receiving end | ||
| @deprecated This function is deprecated, and is only here to keep backward | ||
| compatibility with old xapis that call Remote.DATA.MIRROR.receive_finalize |
Member
There was a problem hiding this comment.
Suggested change
| compatibility with old xapis that call Remote.DATA.MIRROR.receive_finalize | |
| compatibility with old xapis that call Remote.DATA.MIRROR.receive_finalize2 |
psafont
approved these changes
May 13, 2025
edwintorok
approved these changes
May 13, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Sorry guys, forgot about
receive_finalize2🤪. I hope there is no more....