CA-409482: Using computed delay for RRD loop #6458
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lindig
approved these changes
May 8, 2025
BengangY
force-pushed
the
private/bengangy/CA-409482
branch
from
a289be7 to
35dcd13
Compare
last-genius
approved these changes
May 8, 2025
Contributor
|
LGTM! |
Contributor
|
Can we updraft this? |
Contributor
Author
You mean 'undraft'? I'm making more testing for it. If it works well, I will undraft it. |
psafont
reviewed
May 12, 2025
BengangY
force-pushed
the
private/bengangy/CA-409482
branch
from
35dcd13 to
3bc9fae
Compare
psafont
reviewed
May 14, 2025
psafont
reviewed
May 14, 2025
psafont
reviewed
May 14, 2025
psafont
reviewed
May 14, 2025
psafont
reviewed
May 14, 2025
BengangY
force-pushed
the
private/bengangy/CA-409482
branch
from
3bc9fae to
c08ac31
Compare
psafont
reviewed
May 16, 2025
psafont
reviewed
May 16, 2025
BengangY
force-pushed
the
private/bengangy/CA-409482
branch
2 times, most recently
from
c6f4781 to
dac7a66
Compare
psafont
reviewed
May 21, 2025
psafont
reviewed
May 21, 2025
psafont
reviewed
May 21, 2025
psafont
reviewed
May 21, 2025
Member
psafont
left a comment
psafont
left a comment
There was a problem hiding this comment.
I think with Timer is both shorter, and easier to understand, let me know what you think
BengangY
force-pushed
the
private/bengangy/CA-409482
branch
from
dac7a66 to
b0631f5
Compare
Vincent-lau
approved these changes
May 21, 2025
edwintorok
reviewed
May 21, 2025
edwintorok
reviewed
May 21, 2025
RRD loop is executed each 5 seconds. It delays fixed 5 seconds between each loop. But the loop self also consumes time (The time consuming depends on CPU's count. If there are many CPUs, the time consuming may be hundreds milliseconds). This implementation leads RRD will take an offset after several loops. Then one of RRD data lose and a gap can be observed on XenCenter performance graph. The solution is to use a fixed deadline as each iteration start time and to use a computed delay (timeslice - loop time consuming) instead of fixed delay. Signed-off-by: Bengang Yuan <[email protected]>
BengangY
force-pushed
the
private/bengangy/CA-409482
branch
from
b0631f5 to
b947e1e
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
RRD loop is executed each 5 seconds. It delays fixed 5 seconds between each loop. But the loop self also consumes time (The time consuming depends on CPU's count. If there are many CPUs, the time consuming may be hundreds milliseconds). This implementation leads RRD will take an offset after several loops. Then one of RRD data lose and a gap can be observed on XenCenter performance graph.
The solution is to use computed delay (timeslice - loop time consuming) instead of fixed delay.