CP-53478: Implement SSH-related APIs for Dom0 SSH control #6394

LunfanZhang · 2025-03-31T07:54:43Z

Implemented XAPI APIs:

set_ssh_enabled_timeout
set_console_idle_timeout

These APIs allow XAPI to configure timeouts for the SSH service and idle console sessions from both host and pool level.

Updated records.ml to support host-param-set/get/list and pool-param-set/get/list for SSH-related fields.

ocaml/xapi/xapi_host.ml

ocaml/idl/datamodel_errors.ml

ocaml/xapi-cli-server/records.ml

ocaml/xapi/xapi_host.ml

robhoes · 2025-03-31T15:26:37Z

Please get used to splitting things up into separate commits. In this case you could easily have one commit for each API.

LunfanZhang · 2025-04-01T07:21:11Z

Please get used to splitting things up into separate commits. In this case you could easily have one commit for each API.

I split it into three commits, including both API changes and one CLI change. I believe it's clearer now.

ocaml/xapi/xapi_host.ml

gangj · 2025-04-02T05:22:23Z

The first commit msg:

Implemented XAPI APIs:
  - `set_console_idle_timeout`

This API allow XAPI to configure timeouts for the idle console sessions.

->

Implemented XAPI APIs:
  - `host.set_console_idle_timeout`
  - `pool.set_console_idle_timeout`

These APIs allow XAPI to configure timeout for idle console sessions.

For 2nd one:

Implemented XAPI API:
  - `set_ssh_enabled_timeout`
This API allow XAPI to configure timeouts for the SSH service.

->

Implemented XAPI APIs:
  - `host.set_ssh_enabled_timeout`
  - `pool.set_ssh_enabled_timeout`
These APIs allow XAPI to configure timeout for SSH service.

And would be good to also mentioning that host.enable_ssh and host.disable_ssh are updated to support "ssh_enabled_timeout"

ocaml/xapi/xapi_host.ml

ocaml/xapi-cli-server/records.ml

ocaml/xapi/xapi_host.ml

ocaml/xapi-cli-server/records.ml

ocaml/xapi/xapi_host.ml

ocaml/xapi/xapi_globs.ml

ocaml/xapi-cli-server/records.ml

ocaml/xapi/xapi_host.ml

Implemented XAPI APIs: - `host.set_console_idle_timeout` - `pool.set_console_idle_timeout` These APIs allow XAPI to configure timeout for idle console sessions. Signed-off-by: Lunfan Zhang <[email protected]>

Implemented XAPI APIs: - `host.set_ssh_enabled_timeout` - `pool.set_ssh_enabled_timeout` These APIs allow XAPI to configure timeout for SSH service. `host.enable_ssh` now also supports enabling the SSH service with a ssh_enabled_timeout Signed-off-by: Lunfan Zhang <[email protected]>

Updated `records.ml` file to support `host-param-set/get/list` and `pool-param-set/get/list` for SSH-related fields. Signed-off-by: Lunfan Zhang <[email protected]>

LunfanZhang force-pushed the private/lunfan/CP-53478 branch from 2b4cf41 to 38b776b Compare March 31, 2025 08:21

BengangY reviewed Mar 31, 2025

View reviewed changes

ocaml/xapi/xapi_host.ml Outdated Show resolved Hide resolved

lindig approved these changes Mar 31, 2025

View reviewed changes

ocaml/idl/datamodel_errors.ml Outdated Show resolved Hide resolved

ocaml/xapi-cli-server/records.ml Show resolved Hide resolved

ocaml/xapi/xapi_host.ml Outdated Show resolved Hide resolved

ocaml/xapi/xapi_host.ml Outdated Show resolved Hide resolved

LunfanZhang force-pushed the private/lunfan/CP-53478 branch from 38b776b to e157273 Compare April 1, 2025 07:09

LunfanZhang requested review from BengangY and robhoes April 1, 2025 07:31

LunfanZhang force-pushed the private/lunfan/CP-53478 branch 2 times, most recently from 137eebb to 7259d11 Compare April 2, 2025 03:31