CP-53477 Update Host/Pool Data model to Support Dom0 SSH Control #6388
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
LunfanZhang
force-pushed
the
private/lunfan/CP-53477
branch
2 times, most recently
from
ec522fd to
7a7f942
Compare
minglumlu
reviewed
Mar 25, 2025
minglumlu
reviewed
Mar 25, 2025
BengangY
reviewed
Mar 25, 2025
BengangY
reviewed
Mar 25, 2025
minglumlu
reviewed
Mar 25, 2025
robhoes
reviewed
Mar 25, 2025
robhoes
reviewed
Mar 25, 2025
robhoes
reviewed
Mar 25, 2025
robhoes
reviewed
Mar 25, 2025
robhoes
reviewed
Mar 25, 2025
LunfanZhang
force-pushed
the
private/lunfan/CP-53477
branch
from
7a7f942 to
64d5d93
Compare
robhoes
reviewed
Mar 25, 2025
robhoes
reviewed
Mar 25, 2025
robhoes
reviewed
Mar 25, 2025
LunfanZhang
force-pushed
the
private/lunfan/CP-53477
branch
from
64d5d93 to
6875825
Compare
robhoes
reviewed
Mar 26, 2025
…onfigure Add new host object fields: - ssh_enabled - ssh_enabled_timeout - ssh_expiry - console_idle_timeout Add new host/pool API to enable to set a temporary enabled SSH service timeout - set_ssh_enabled_timeout Add new host/pool API to enable to set console timeout - set_console_idle_timeout Signed-off-by: Lunfan Zhang <[email protected]>
LunfanZhang
force-pushed
the
private/lunfan/CP-53477
branch
from
6875825 to
12e5680
Compare
BengangY
reviewed
Mar 27, 2025
BengangY
approved these changes
Mar 27, 2025
robhoes
approved these changes
Mar 27, 2025
gangj
reviewed
Mar 27, 2025
| ~params: | ||
| [ | ||
| (Ref _host, "self", "The host") | ||
| ; (Int, "value", "The idle console timeout in seconds") |
Collaborator
Author
There was a problem hiding this comment.
Both are grammatically correct, I will keep this
Contributor
There was a problem hiding this comment.
Yes, would be better to keep identical to the other places.
gangj
reviewed
Mar 27, 2025
minglumlu
merged commit 2f00a21
into
xapi-project:feature/configure-ssh-phase2
17 checks passed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR introduces support for Dom0 SSH control, providing the following capabilities:
Query the SSH status.
Configure a temporary SSH enable timeout for a specific host or all hosts in the pool.
Configure the console idle timeout for a specific host or all hosts in the pool.
Changes
New Host Object Fields:
ssh_enabled: Indicates whether SSH is enabled.ssh_enabled_timeout: Specifies the timeout for temporary SSH enablement.ssh_expiry: Tracks the expiration time for temporary SSH enablement.console_idle_timeout: Configures the idle timeout for the console.New Host/Pool APIs (This PR only include the change of data model, the implementation of this API will be include in the next PR):
set_ssh_enabled_timeout: Allows setting a temporary timeout for enabling the SSH service.set_console_idle_timeout: Allows configuring the console idle timeout.