Skip to content

Conversation

@dav1do
Copy link

@dav1do dav1do commented Dec 7, 2021

  • Add 2020-03-02 and 2020-08-27 API versions to the enum
  • Set API header 2020-03-02 on the client. This is a breaking change but 0.13 is supposed to target 2020-03-02 according to the readme.

Questions:

  • Does openAPI spec regen need to happen?
  • Since Stripe uses the version of your account if you don't pass the header, it seems nice to leave off/add a new_with_version constructor, however there are probably compatibility issues with the generated types in that case, so maybe the library can only support one version at a time.

@dav1do dav1do force-pushed the fix/update-api-version branch from ca0a4a5 to 23b8222 Compare December 7, 2021 18:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants