several bug fixes to client #192
Conversation
daringordon
changed the title
|
| impl<'a> CreateSetupIntent<'a> { | ||
| pub fn new() -> Self { | ||
| CreateSetupIntent { | ||
| confirm: Default::default(), |
There was a problem hiding this comment.
Should this fn just return Default::default()?
|
|
||
| #[derive(Copy, Clone, Debug, Deserialize, Serialize, Eq, PartialEq)] | ||
| pub enum CardBrand { | ||
| #[serde(rename = "American Express")] |
There was a problem hiding this comment.
I don't think this is safe -
https://stripe.com/docs/api/cards/object#card_object-brand
Would this meet your needs? #188
There was a problem hiding this comment.
#188 has now been merged. The enum PaymentMethodCardBrand now holds variants that would be helpful here.
|
I think this looks good other than the CardBrand issue - if #188 meets your needs for that portion, I'm happy merging the other parts. |
|
Thanks for the review, @stearnsc! @daringordon, would you be interested in submitting separate PRs for these different changes? I believe the first change has now been covered by #141. |
|
OK. I'm closing this PR as two of the commits in it were addressed by 188 and 141. This PR is now replaced by a reduced version: #202 |
5 participants
see: https://stripe.com/docs/api/charges/object#charge_object-payment_method_details-card-brand