Skip to content

Conversation

@barlage
Copy link
Contributor

@barlage barlage commented Jan 2, 2019

Update Noah-MP with National Water Model changes

TYPE: enhancement

KEYWORDS: Noah-MP

SOURCE: Michael Barlage (NCAR)

DESCRIPTION OF CHANGES:

Noah-MP code within WRF and the National Water Model has diverged. This pull request feeds NWM development back to WRF.

LIST OF MODIFIED FILES:

M phys/module_sf_noahmpdrv.F
M phys/module_sf_noahmplsm.F
M run/MPTABLE.TBL

TESTS CONDUCTED:

  1. 24-hour summer/winter simulations produces expected level of changes

@barlage barlage requested a review from a team as a code owner January 2, 2019 21:24
@kkeene44 kkeene44 requested a review from a team January 11, 2019 17:29
Copy link
Collaborator

@dudhia dudhia left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approve - impact on rest of code minimal

Copy link
Contributor

@davegill davegill left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

approved

@davegill davegill merged commit 5dfdc82 into wrf-model:develop Jan 11, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants