Fix relative pathing for tuv_kpp initial code generation #2256
+1
−1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
TYPE: bug fix
KEYWORDS: chem, make
SOURCE: internal
DESCRIPTION OF CHANGES:
Problem:
PR #2018 Changed how KPP helper programs generate code by now accepting relative paths. The relative path passed into
tuv_kppfor the first part of generation is wrong and should match the relative paths used in the other calls. Using the wrong path causes KPP compilation with the make build to fail with incorrect Fortran syntax in the kpp mechanism case selection.Solution:
Change the
tuv_kpprelative path to match all other calls, thus operating on the same set of files generated in that directory.TESTS CONDUCTED:
RELEASE NOTE: Include a stand-alone message suitable for the inclusion in the minor and annual releases. A publication citation is appropriate.