CMake Fix ideal compilation #2229
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mgduda
approved these changes
May 30, 2025
weiwangncar
approved these changes
May 30, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
TYPE: bug fix
KEYWORDS: cmake, ideal
SOURCE: internal
DESCRIPTION OF CHANGES:
Problem:
PR #2089 introduced the ability to compile WRFPLUS, however it inadvertently removed the compilation of
wrf[.exe]from any configurations that weren'tPLUSor 'EM_REAL. Thus, the ideal cases underARWcore but notEM_REALno longer compiled thewrf` target, effectively breaking compilation for any ideal cases.Solution:
Adjust the logic to compile the
wrfexecutable forARWorPLUScores.ISSUE: For use when this PR closes an issue.
Fixes #2224
TESTS CONDUCTED:
RELEASE NOTE:
CMake bug fix to ensure ideal cases compile correctly again.