Skip to content

Conversation

@saneku
Copy link
Contributor

@saneku saneku commented Mar 26, 2025

Removed unnecessary factor in computation of dry air density in module_chem_utilities.F

TYPE: bug fix

KEYWORDS: WRF-Chem, dry air density

SOURCE: NOAA GSL, Alexander Ukhov (KAUST)

DESCRIPTION OF CHANGES:
Problem:
It was found that dry air density was miscalculated.

Solution:
Removed unnecessary factor. Simulations before and after did not show any significant difference, as expected.

before_and_after

LIST OF MODIFIED FILES:
M chem/module_chem_utilities.F

TESTS CONDUCTED:

  1. Do mods fix problem? How can that be demonstrated, and was that test conducted?
  2. Are the Jenkins tests all passing?

RELEASE NOTE: Fixed calculation of dry air density in module_chem_utilities.F. The bug had a very minor effect.

@saneku saneku requested a review from a team as a code owner March 26, 2025 19:40
Copy link
Contributor

@jordanschnell jordanschnell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for this bug fix!

@weiwangncar
Copy link
Collaborator

The regression test results:

Test Type              | Expected  | Received |  Failed
= = = = = = = = = = = = = = = = = = = = = = = =  = = = =
Number of Tests        : 23           24
Number of Builds       : 60           57
Number of Simulations  : 158           150        0
Number of Comparisons  : 95           86        0

Failed Simulations are: 
None
Which comparisons are not bit-for-bit: 
None

@weiwangncar weiwangncar merged commit cb58c0b into wrf-model:develop Apr 1, 2025
2 checks passed
@saneku saneku deleted the bug_fix_in_chem_utils branch April 1, 2025 21:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants