Skip to content

Fix the bug: TUV photolysis is inactive if simulation starts on 1st Jan #2171

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Apr 1, 2025
Merged

Fix the bug: TUV photolysis is inactive if simulation starts on 1st Jan #2171

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
0fe10c9
Fix the bug: photolysis is inactive if simulation starts on 1st Jan
SeregaOsipov Feb 26, 2025
cbdb831
Fix the bug: photolysis is inactive if simulation starts on 1st Jan
SeregaOsipov Feb 26, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 5 additions & 4 deletions chem/module_ftuv_driver.F
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1308,10 +1308,11 @@ subroutine ftuv_timestep_init( id, julday )
!-----------------------------------------------------------------------------
! set solar distance factor
!-----------------------------------------------------------------------------
if( curjulday /= julday ) then
curjulday = julday
call sundis( curjulday, esfact )
endif
! osipov fix the bug. Always calc the distance. Testing for 0 results in True on 1 Jan, keeps the sfact=0 and shutsdown the photolysis for entire day
!if( curjulday /= julday ) then
curjulday = julday
call sundis( curjulday, esfact )
!endif

end subroutine ftuv_timestep_init

Expand Down
9 changes: 5 additions & 4 deletions chem/module_phot_tuv.F
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -341,10 +341,11 @@ subroutine tuv_driver( &
!-----------------------------------------------------------------------------
! set solar distance factor
!-----------------------------------------------------------------------------
if( curjulday /= julday ) then
curjulday = julday
esfact = sundis( julday )
endif
! osipov fix the bug. Always calc the distance. Testing for 0 results in True on 1 Jan, keeps the sfact=0 and shutsdown the photolysis for entire day
!if( curjulday /= julday ) then
curjulday = julday
esfact = sundis( julday )
!endif
if( .not. config_flags%scale_o3_to_grnd_exo_coldens ) then
if( config_flags%scale_o3_to_du_at_grnd ) then
dobsi = max( 0.,config_flags%du_at_grnd )
Expand Down