Skip to content

Refactor user info retrieval methods #100

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Nov 11, 2025
Merged

Refactor user info retrieval methods #100

merged 1 commit into from
Nov 11, 2025

Conversation

@ribsey
Copy link
Contributor

@ribsey ribsey commented Nov 10, 2025

fix the following warnings on periodic pulls as no user is logged in:

E_WARNING: Trying to access array offset on null/storage/lib/plugins/gitbacked/action/editcommit.php(96)
#0 /storage/lib/plugins/gitbacked/action/editcommit.php(96): dokuwiki\ErrorHandler::errorHandler()
#1 /storage/lib/plugins/gitbacked/action/editcommit.php(51): action_plugin_gitbacked_editcommit->getAuthor()
#2 /storage/lib/plugins/gitbacked/action/editcommit.php(149): action_plugin_gitbacked_editcommit->initRepo()
#3 /var/www/html/inc/Extension/EventHandler.php(80): action_plugin_gitbacked_editcommit->handle_periodic_pull()
E_WARNING: Trying to access array offset on null/storage/lib/plugins/gitbacked/action/editcommit.php(100)
#0 /storage/lib/plugins/gitbacked/action/editcommit.php(100): dokuwiki\ErrorHandler::errorHandler()
#1 /storage/lib/plugins/gitbacked/action/editcommit.php(51): action_plugin_gitbacked_editcommit->getAuthorMail()
#2 /storage/lib/plugins/gitbacked/action/editcommit.php(149): action_plugin_gitbacked_editcommit->initRepo()
#3 /var/www/html/inc/Extension/EventHandler.php(80): action_plugin_gitbacked_editcommit->handle_periodic_pull()

@ribsey
Refactor user info retrieval methods
19993fa 
fix warnings:
E_WARNING: Trying to access array offset on null/storage/lib/plugins/gitbacked/action/editcommit.php(96)

E_WARNING: Trying to access array offset on null/storage/lib/plugins/gitbacked/action/editcommit.php(100)
@mhoffrog mhoffrog self-requested a review November 11, 2025 16:03
@mhoffrog mhoffrog added the bug label Nov 11, 2025
@mhoffrog mhoffrog self-assigned this Nov 11, 2025
mhoffrog
mhoffrog approved these changes Nov 11, 2025
View reviewed changes
Copy link
Collaborator

@mhoffrog mhoffrog left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@ribsey 👍 LGTM - many THANKS for your contribution!

@mhoffrog mhoffrog merged commit 7c633d2 into woolfg:master Nov 11, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@mhoffrog mhoffrog mhoffrog approved these changes

Assignees

@mhoffrog mhoffrog

Labels

bug

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@ribsey @mhoffrog