This repository was archived by the owner on Feb 23, 2024. It is now read-only.
Fix undefined index for saved_cards
#2580
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nerrad
added
status: needs review
type: bug
Contributor
|
Size Change: 0 B Total Size: 2.06 MB ℹ️ View Unchanged
|
Aljullu
approved these changes
May 27, 2020
nerrad
added a commit
that referenced
this pull request
May 27, 2020
nerrad
added
the
release: cherry-pick
nerrad
added a commit
that referenced
this pull request
May 27, 2020
nerrad
added a commit
that referenced
this pull request
May 27, 2020
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes: #2575
See the report in #2575. The fix in this pull is fairly straightforward.
To Test
There's not a whole lot to test here, the code is basic defensive programming. However as a confidence check, you can smoke check that saved payment methods still show up in the checkout block on the frontend if the logged in user has any.