-
Notifications
You must be signed in to change notification settings - Fork 184
PlatformIO ESP-IDF esp-tls component update #517
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is there not a way to provide a link to download this bundle (.zip) from the source? I don't like the maintenance required to keep a .zip here.
@dgarske That's an excellent question. In this case, the source is a release created on my repo fork of ESP-IDF v5.3.1. That fork has my working changes for wolfSSL eps-tls component support in the ESP-IDF. I still need to create upstream PR in addition the the one mentioned in the description. ESP-IDF v5.5 was already in beta RC preview when I submitted it. Creating a PlatformIO realease is a complex and unintuitive process. Big thanks to @Jason2866 for help, see gojimmypi/esp-idf#1 Maintenance of a zip here would be only until there's upstream support at Espressif and PlatformIO. I don't expect it to be in the near future. I also don't anticipate any other pseudo-releases. This is only a working proof-of-concept example. I agree this a a less-than-ideal solution. An alternative might be to have our own fork of ESP-IDF at wolfSSL. But that would only open up even more complex maintenance issues. My recommendation is to only support official releases. Perhaps I've talked myself out of this PR being a good idea. |
The problem is that creating a release, without extra taking care, does not include git submodules. So the zip file is useless since a lot of stuff is missing. To have a complete working package a GitHub Actions is used for creating a zip with all included. @gojimmypi imho to make it maintainable you should automate the process with Github Actions |
Hi @Jason2866 ! Good to hear from you & thanks for your input.
The zip file in this PR? To clarify: the zip in this PR is the one from my release. To test: I changed the
I completely agree, but I'm not convinced wolfSSL should be in the ESP-IDF fork business. Also not my decision. :) |
Seems i missed what's the question here. |
It is my understanding that @dgarske 's concern is the zip blob hosted here, and not a more obviously generated release. I see the problem: as other than manual inspection, there's no other way to link the zip here with the code used to generate it. This PR was created with the intention of a more stable, official example of using my esp-tls updates in PlatformIO. @Jason2866 I roped you in for credit on all the help you provided generating my release, as well as any thoughts you might have regarding using the copy of the zip file here. |
Creates a wolfssl-hosted Platformio
esp-idf-v5.3.1.20240926c.zip
that contains the Espressif ESP-IDF with esp-tls updates.See also:
Tested manually with an edit for my PR directory in
platformio.ini
file:https://github.com/gojimmypi/esp-idf/releases