fix: disable object element handler #122
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
the `object` without `visibility: hidden` may trigger some bugs in `contenteditable`
|
Thanks! |
|
Please REVERT this change. It makes the "object" strategy no longer work in ALL Firefox browsers (tested in Firefox 52 ESR, 78 ESR, 90.0b11) @wnr Please do TEST before you make a pull request! |
|
Hmm that's strange. It seems like it works sometimes and sometimes not in FF. That's why the automated tests failed to catch this error. I'll push a revert for this. |
wnr
added a commit
that referenced
this pull request
Jun 24, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
the
objectwithoutvisibility: hiddenmay trigger some bugs incontenteditable