Skip to content

Conversation

@delucis
Copy link
Member

@delucis delucis commented Aug 9, 2023

What kind of changes does this PR include?

  • Something else!

Description

Our size-limit CI currently checks the docs/dist/_astro/ output for total JS & CSS size, but this makes it tricky for us to add things like #470 as one-off components can breach our budget. As we only really want to ensure a small bundle baseline size, it makes more sense to test against our example projects than docs.

This PR switches across to testing the basics example — unlocked just in time by withastro/astro#7983

(I think this PR will like fail in CI because it tries to run the same script on the PR branch and on main, but the required script isn’t on main yet.)

For the record a comparison of a recent run for docs on main currently and the new results running against the basics example:

docs basics
/index.html 13.49 kB 9.59 kB
/_astro/*.js 16.94 kB 16.23 kB
/_astro/*.css 8.75 kB 8.56 kB

As expected, the basics is smaller, but only slightly apart from the home page which has less content and no language switcher markup.

@changeset-bot
Copy link

changeset-bot bot commented Aug 9, 2023

⚠️ No Changeset found

Latest commit: e11fe99

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@netlify
Copy link

netlify bot commented Aug 9, 2023

Deploy Preview for astro-starlight ready!

Name Link
🔨 Latest commit e11fe99
🔍 Latest deploy log https://app.netlify.com/sites/astro-starlight/deploys/64d40d277c72510008bc5b01
😎 Deploy Preview https://deploy-preview-477--astro-starlight.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@github-actions github-actions bot added 🚨 action Changes to GitHub Action workflows 📚 docs Documentation website changes 🌟 core Changes to Starlight’s main package labels Aug 9, 2023
@delucis delucis merged commit bf91e27 into main Aug 9, 2023
@delucis delucis deleted the chris/size-limit branch August 9, 2023 22:13
Yoxnear pushed a commit to Yoxnear/starlight-custom that referenced this pull request Jul 23, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

🚨 action Changes to GitHub Action workflows 🌟 core Changes to Starlight’s main package 📚 docs Documentation website changes

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants