Skip to content

Fix issue with nested <Tabs> components #473

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Aug 8, 2023
Merged

Fix issue with nested <Tabs> components #473

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
cd7d741
fix: nested tabs
HiDeoo Aug 8, 2023
3fbc696
chore: add changeset
HiDeoo Aug 8, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions .changeset/wise-boats-flow.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,5 @@
---
'@astrojs/starlight': patch
---

Fix issue with nested `<Tabs>` components
2 changes: 1 addition & 1 deletion packages/starlight/user-components/Tabs.astro
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -77,7 +77,7 @@ const { html, panels } = processPanels(panelHtml);
super();
const tablist = this.querySelector<HTMLUListElement>('[role="tablist"]')!;
this.tabs = [...tablist.querySelectorAll<HTMLAnchorElement>('[role="tab"]')];
Copy link
Member

@delucis delucis Aug 8, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Don’t we need a similar approach for this selector too?

Copy link
Member Author

@HiDeoo HiDeoo Aug 8, 2023 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We actually do not (which is quite neat as those are not direct children and would need longer selectors):

  • The first one is using querySelector() and not querySelectorAll() so it only return the first result which is what we want.
  • The second one is based on the result of the first one so it's also what we want.

Basically only the last one was an issue as it was based on the component (this) and was using querySelectorAll().

this.panels = [...this.querySelectorAll<HTMLElement>('[role="tabpanel"]')];
this.panels = [...this.querySelectorAll<HTMLElement>(':scope > [role="tabpanel"]')];

this.tabs.forEach((tab, i) => {
// Handle clicks for mouse users
Expand Down