Skip to content

Conversation

@delucis
Copy link
Member

@delucis delucis commented Aug 7, 2023

What kind of changes does this PR include?

  • Changes to Starlight code

Description

Fixes an (intentional) type error in the Starlight integration (by explicitly ignoring it). The code that errors is required to support versions of Astro below v2.6, but can be picked up as an error by users running tsc in some circumstances.

@changeset-bot
Copy link

changeset-bot bot commented Aug 7, 2023

🦋 Changeset detected

Latest commit: 4fa37a9

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@astrojs/starlight Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@netlify
Copy link

netlify bot commented Aug 7, 2023

Deploy Preview for astro-starlight ready!

Name Link
🔨 Latest commit 4fa37a9
🔍 Latest deploy log https://app.netlify.com/sites/astro-starlight/deploys/64d1587c7c1689000803f37d
😎 Deploy Preview https://deploy-preview-467--astro-starlight.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@github-actions github-actions bot added the 🌟 core Changes to Starlight’s main package label Aug 7, 2023
@github-actions github-actions bot added the 📚 docs Documentation website changes label Aug 7, 2023
@astrobot-houston
Copy link
Contributor

size-limit report 📦

Path Size
/index.html 13.17 KB (0%)
/_astro/*.js 16.55 KB (0%)
/_astro/*.css 8.55 KB (0%)

@delucis delucis merged commit 461a5d5 into main Aug 7, 2023
@delucis delucis deleted the chris/fix-type-error branch August 7, 2023 20:54
@astrobot-houston astrobot-houston mentioned this pull request Aug 7, 2023
Yoxnear pushed a commit to Yoxnear/starlight-custom that referenced this pull request Jul 23, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

🌟 core Changes to Starlight’s main package 📚 docs Documentation website changes

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants