Sidebar current page highlight with trailing slashes

[HiDeoo]

What kind of changes does this PR include?

• Changes to Starlight code

Description

As discussed on Discord, this PR fixes the current page highlight in the sidebar for URLs with no trailing slash.

This Discord thread also discusses why this PR does not handle Astro trailingSlash and build.format options for the sidebar isCurrent check which is purposefully lenient. These options should be handled in #207.

My initial suggestion on Discord was to use const isCurrent = href === currentPathname.replace(/\/?$/, '/'); but instead I used the same approach as the existing ensureLeadingAndTrailingSlashes() function for multiple reasons:

• Consistency
• Might be slightly easier to understand for someone not used to regex
• According to this bench, this is faster. Not sure it's properly benchmarked or if it even matters in this case but might as well use the faster option ^^

[changeset-bot]

🦋 Changeset detected

Latest commit: e67bf8a

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package

Name	Type
@astrojs/starlight	Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

[netlify]

✅ Deploy Preview for astro-starlight ready!

Name	Link
🔨 Latest commit	e67bf8a
🔍 Latest deploy log	https://app.netlify.com/sites/astro-starlight/deploys/64d15e091be7320008baa5ed
😎 Deploy Preview	https://deploy-preview-460--astro-starlight.netlify.app
📱 Preview on mobile	Toggle QR Code... Use your smartphone camera to open QR code link.

---

To edit notification comments on pull requests, go to your Netlify site configuration.

[delucis]

Thanks @HiDeoo — LGTM! Left one refactor suggestion, but doesn’t have to be part of this PR if you don’t think it’s important.

[HiDeoo]

Moved all these helpers to a new dedicated file and indeed, as expected, according to the same benchmark tool, the stripping regexp version was also slower.

[delucis]

Thank you @HiDeoo!