Skip to content

Add exception message to logging when mapping fails due to an exception. #1248

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Jan 30, 2025
Merged

Add exception message to logging when mapping fails due to an exception. #1248

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
eb7cf46
Add exception message to logging when mapping fails due to an exception.
JvE-iO Jan 29, 2025
eafc42b
Merge branch 'WireMock-Net:master' into patch-1
JvE-iO Jan 30, 2025
4951ef3
Revert "Add exception message to logging when mapping fails due to an…
JvE-iO Jan 30, 2025
2e247ff
Fix loggers with improved exception logging.
JvE-iO Jan 30, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions examples/WireMock.Net.WebApplication.NET6/WireMockService.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -52,9 +52,9 @@ public void DebugRequestResponse(LogEntryModel logEntryModel, bool isAdminreques
_logger.LogDebug("Admin[{0}] {1}", isAdminrequest, message);
}

public void Error(string formatString, Exception exception)
public void Error(string message, Exception exception)
{
_logger.LogError(formatString, exception.Message);
_logger.LogError(exception, message);
}
}

Expand Down
4 changes: 2 additions & 2 deletions src/WireMock.Net.TUnit/TUnitWireMockLogger.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -51,9 +51,9 @@ public void Error(string formatString, params object[] args)
}

/// <inheritdoc />
public void Error(string formatString, Exception exception)
public void Error(string message, Exception exception)
{
_tUnitLogger.LogError(Format("Error", formatString, exception.Message), exception);
_tUnitLogger.LogError(Format("Error", $"{message} {{0}}", exception));

if (exception is AggregateException ae)
{
Expand Down
6 changes: 3 additions & 3 deletions src/WireMock.Net.xUnit/TestOutputHelperWireMockLogger.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -50,15 +50,15 @@ public void Error(string formatString, params object[] args)
}

/// <inheritdoc />
public void Error(string formatString, Exception exception)
public void Error(string message, Exception exception)
{
_testOutputHelper.WriteLine(Format("Error", formatString, exception.Message));
_testOutputHelper.WriteLine(Format("Error", $"{message} {{0}}", exception));

if (exception is AggregateException ae)
{
ae.Handle(ex =>
{
_testOutputHelper.WriteLine(Format("Error", "Exception {0}", ex.Message));
_testOutputHelper.WriteLine(Format("Error", "Exception {0}", ex));
return true;
});
}
Expand Down