Skip to content
This repository was archived by the owner on Jan 15, 2022. It is now read-only.

Conversation

@cecilemuller
Copy link
Member

@cecilemuller cecilemuller commented Sep 9, 2020

Updated css-loader, mini-css-extract-plugin, postcss-loader, and sass-loader.

Some tests fail and the major update of postcss-loader is the most likely cause so far (usually it turns out to be small things like an option got renamed), especially as Dependabot hasn't yet created a PR for the postcss-loader update whereas the PR for the other 3 dependency updates pass tests just fine.

@cecilemuller cecilemuller added the dependencies Pull requests that update a dependency file label Sep 9, 2020
@cecilemuller
Copy link
Member Author

cecilemuller commented Sep 9, 2020

I strongly suspect it's due to the new option postcssOptions to pass plugins to PostCSS.

Before:

{
	"loader": "postcss-loader",
	"options": {
		"plugins": [
			"postcss-preset-env"
		]
	}
}

Now:

{
	"loader": "postcss-loader",
	"options": {
		"postcssOptions": {
			"plugins": [
				"postcss-preset-env"
			]
		}
	}
}

However I'm not sure if ident is an option from PostCSS itself or from the loader (it's been a while).

@cecilemuller
Copy link
Member Author

After more digging into it, it sounds like ident used to be from the loader, but isn't required anymore, in which case I should be able to remove it.

@cecilemuller cecilemuller merged commit badff5e into master Sep 9, 2020
@cecilemuller cecilemuller deleted the features/updates branch September 9, 2020 16:22
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

dependencies Pull requests that update a dependency file

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants