fix: block scope all variable reuses to fix trailing "optional" length check #111
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A bug in #109; many of the unmarshal components just reuse the primary
maj, extra, errvariables forcr.ReadHeader(), so that when you get to the end and want to useextrato length-check, it's already been overwritten with something else. This doesn't show up in the current tests becauseint64happens to block scope and create new variables. But uint64 doesn't, so that's included in the test now and it fails without the fix. I remember hitting this when I was doing the generics work too.This is the "hard way" (proper way) of fixing it and makes a lot of churn in generated output.
#112 is the easy way of fixing it.
We can debate and pick one.