-
Notifications
You must be signed in to change notification settings - Fork 184
Replace incorrect "async iterable" token to "async_iterable" #1489
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
And this caught a grammar problem: Seems we should change the grammar? |
|
How widely deployed is this type? I suspect not very if at all? I wouldn't mind making it |
lucacasonato
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
|
Added comments to the same bugs filed by #1397 as most of them are still open. |
|
widlparser merged the original PR and applied the grammar change, so bikeshed is good to go once they get the new dependency. Do we have any other blockers here? |
This changes the
async iterablegrammar added by #1397 toasync_iterableso that the grammar can stay withinLL(1)rule.Fixes #1490
async iterableshould be converted toasync_iterabledenoland/deno#30020async_iterable<T>WebIDL type nodejs/node#54175 (comment)async_sequence<T>type w3c/webidl2.js#775 (comment) (the comment is enough for me as a maintainer)async_iterable<T>plinss/widlparser#90(See WHATWG Working Mode: Changes for more details.)
Preview | Diff
Don't remove this comment or modify anything below this line.
If you don't want a preview generated for this pull request,
just replace the whole of this comment's content by "no preview"
and remove what's below.
-->
Preview (#Don't…) (<a href="https://whatpr.org/webidl/1489.html#just replace the whole of this comment's content by "no preview"
and remove what's below.
-->
<a href="https://whatpr.org/webidl/1489.html" title="Last updated on Jun 8" title="#just replace the whole of this comment's content by "no preview"
and remove what's below.
-->
#just…) (#2025) (Preview | Preview | #9:00…) (#2025) (Diff" title="#9:00 PM UTC (e2b04a8)">Diff">#9:00…) | Diff