Remove connectedness check in script post-connection steps #11543
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
9 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Removing the PR template since this doesn't impact behavior. In whatwg/dom@b31d333, we decided that the post-connection steps should have a connectedness pre-condition, so that post-connection steps themselves didn't have to check this manually, which feels redundant.
However, this didn't quite make it over to HTML when I wrote the script post-connection steps, as there is a connectedness check and an detailed example about how an earlier-inserted script can remove a later-inserted script. It just so happens that the connectedness check in the script element's isn't actually redundant though, because this algorithm is called from the "children changed steps" and "attribute change steps", without connectedness pre-conditions.
This PR simplifies things and keeps the post-connection steps more true to its name, by making all of its callsites have a connectedness pre-condition, and removing the weird check from the post-connection steps.
/scripting.html ( diff )