Skip to content

Allow setting a maxAge #292

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 6 commits into
base: main
Choose a base branch
from
Open

Allow setting a maxAge #292

Changes from 2 commits
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
dc6409d
specify max-age option
aamuley Nov 13, 2025
39eedf1
add ToString
aamuley Nov 13, 2025
04671d9
only allow one of max-age, expires
aamuley Nov 19, 2025
a031426
fix whitespace
aamuley Nov 19, 2025
1becf81
use maxAge in delete a cookie
aamuley Nov 21, 2025
6f6ccf4
remove alg
aamuley Nov 21, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
28 changes: 17 additions & 11 deletions index.bs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -27,8 +27,8 @@ Level: 1

<pre class=anchors>
spec: ecma262; urlPrefix: https://tc39.github.io/ecma262/
type: dfn
text: time values; url: sec-time-values-and-time-range
type: dfn; text: time values; url: sec-time-values-and-time-range
type: dfn; text: ToString; url: sec-tostring
</pre>

<pre class=link-defaults>
Expand Down Expand Up @@ -490,6 +490,7 @@ dictionary CookieInit {
USVString path = "/";
CookieSameSite sameSite = "strict";
boolean partitioned = false;
long long? maxAge = null;
};

dictionary CookieStoreDeleteOptions {
Expand Down Expand Up @@ -658,8 +659,9 @@ The <dfn method for=CookieStore>set(|name|, |value|)</dfn> method steps are:
null,
null,
"`/`",
"{{CookieSameSite/strict}}", and
false.
"{{CookieSameSite/strict}}",
false, and
null.
1. If |r| is failure, then [=reject=] |p| with a {{TypeError}} and abort these steps.
1. [=/Resolve=] |p| with undefined.
1. Return |p|.
Expand All @@ -682,8 +684,9 @@ The <dfn method for=CookieStore>set(|options|)</dfn> method steps are:
|options|["{{CookieInit/expires}}"],
|options|["{{CookieInit/domain}}"],
|options|["{{CookieInit/path}}"],
|options|["{{CookieInit/sameSite}}"], and
|options|["{{CookieInit/partitioned}}"].
|options|["{{CookieInit/sameSite}}"],
|options|["{{CookieInit/partitioned}}"], and
|options|["{{CookieInit/maxAge}}"].
1. If |r| is failure, then [=reject=] |p| with a {{TypeError}} and abort these steps.
1. [=/Resolve=] |p| with undefined.
1. Return |p|.
Expand Down Expand Up @@ -1061,8 +1064,9 @@ To <dfn>set a cookie</dfn> given a [=/URL=] |url|,
{{DOMHighResTimeStamp}}-or-null |expires|,
[=/scalar value string=]-or-null |domain|,
[=/scalar value string=] |path|,
[=/string=] |sameSite|, and
[=/boolean=] |partitioned|:
[=/string=] |sameSite|,
[=/boolean=] |partitioned|, and
[=/64-bit signed integer=]-or-null |maxAge|:

1. [=Normalize=] |name|.
1. [=Normalize=] |value|.
Expand Down Expand Up @@ -1107,7 +1111,8 @@ To <dfn>set a cookie</dfn> given a [=/URL=] |url|,
: "{{CookieSameSite/lax}}"
:: [=list/Append=] (\``SameSite`\`, \``Lax`\`) to |attributes|.
</dl>
1. If |partitioned| is true, [=list/Append=] (``Partitioned`\`, \`\`) to |attributes|.
1. If |partitioned| is true, [=list/Append=] (\``Partitioned`\`, \`\`) to |attributes|.
1. If |maxAge| is non-null, then [=list/append=] (\``Max-Age`\`, [=ToString=](|maxAge|)) to |attributes|.
1. Perform the steps defined in [[RFC6265BIS-14#name-storage-model|Cookies § Storage Model]] for when the user agent "receives a cookie" with
|url| as <var ignore>request-uri</var>,
|encodedName| as <var ignore>cookie-name</var>,
Expand Down Expand Up @@ -1154,8 +1159,9 @@ a [=/URL=] |url|,
|expires|,
|domain|,
|path|,
"{{CookieSameSite/strict}}", and
|partitioned|.
"{{CookieSameSite/strict}}",
|partitioned|, and
null.

</div>

Expand Down