Skip to content

Fix issues in datepicker #185

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 26 commits into
base: master
Choose a base branch
from
Open

Fix issues in datepicker #185

wants to merge 26 commits into from

Conversation

@benirose
Copy link

There were two issues in the <datepicker> component that are addressed by this MR:

  • The date passed in was not getting formatted according to the format prop, which can cause unnecessary validation issues
  • The date was being parsed by new Date which comes with all sorts of quirks and problems, and is generally not recommended. We now use date-fns.parse which should avoid these issues.

Also updating the docs to:

  • Show the right default format
  • Take in an ISO date in the demo (as a test of this change)

benirose and others added 26 commits January 31, 2018 15:32
@benirose
Adding async-function prop to typeahead to allow custom async loading…
27a19a7 
… of suggestions. Docs included.
@benirose
Updating package.json so this can be imported as vue2-strap3.
9c0fc8c
@benirose
Add blur event to typeahead.
921cec5
@benirose
Updating some of the names for the new repo.
81588e6
@benirose
New distribution.
b2429c7
@benirose
More updates to readme, load the right file from dist
90847b1
@benirose
Adding readonly and disabled to Typeahead
25026fb
@benirose
Adding clickable prop to accordians for programatic control over wh…
123315c 
…ich panel is open.
@benirose
Adding production env to build script and rebuilding.
5fe6254
@mkopinsky
Make scoped styles actually scoped
e1802c9
@benirose
Merge pull request #2 from waytohealth/radio-scoped-style
d29e17b 
Make scoped styles actually scoped
Fresh webpack build
a2e0c04
Hopefully fix weird build issues by deleting old built assets with th…
03bd073 
…e old name, and pointing bower.json to the new files
@mkopinsky
Merge pull request #3 from waytohealth/build-cleanup
1cc231c 
Fix weird build issues by deleting old built assets with the old name, and pointing bower.json to the new files
2.1.1
cda2eca
@mcgrogan91
Adds more date restriction capabilities
9737f9b 
Allows the user to tell the calendar to prevent past/current/future dates
@mcgrogan91
Adding in a visibility marker for today
b297f0f
@benirose
Fix styling for "today" and adjust code so disabled stuff works.
e582874
@benirose
Use indexOf instead of includes to absolutely ensure BC
3cfefbd
@benirose
Forgot unminified
79ced3c
@benirose
Merge pull request #4 from waytohealth/datepicker-modifications
aa5af40 
Datepicker modifications
Rename module to @waytohealth/vue2-strap3 so we can publish it to npm
bc7ce22
2.2.0
81c8826
@mkopinsky
Merge pull request #5 from waytohealth/change-package-name
0895d8c 
Change package name to @waytohealth/vue2-strap3
2.2.1
8e53511
@benirose
Two fixes to datepicker:
54a8e72 
* Reformat the date on mounted so it displays correctly in the specified format
* use date-fns.parse to prevent any weird UTC issues when no time is included
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@benirose @mkopinsky @mcgrogan91