Skip to content

PerMessageDeflate#cleanup - properly cleanup on close #1618

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Aug 12, 2019
Merged

PerMessageDeflate#cleanup - properly cleanup on close #1618

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
16 changes: 15 additions & 1 deletion lib/permessage-deflate.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -133,6 +133,10 @@ class PerMessageDeflate {
}

if (this._deflate) {
if (this._deflate[kCallback]) {
this._deflate[kCallback]();
}

this._deflate.close();
this._deflate = null;
}
Expand Down Expand Up @@ -312,7 +316,9 @@ class PerMessageDeflate {
zlibLimiter.push((done) => {
this._compress(data, fin, (err, result) => {
done();
callback(err, result);
if (err || result) {
callback(err, result);
}
});
});
}
Expand Down Expand Up @@ -419,6 +425,8 @@ class PerMessageDeflate {
this._deflate.on('data', deflateOnData);
}

this._deflate[kCallback] = callback;

this._deflate.write(data);
this._deflate.flush(zlib.Z_SYNC_FLUSH, () => {
if (!this._deflate) {
Expand All @@ -438,6 +446,12 @@ class PerMessageDeflate {

if (fin) data = data.slice(0, data.length - 4);

//
// Ensure that the callback will not be called again in
// `PerMessageDeflate#cleanup()`.
//
this._deflate[kCallback] = null;

if (fin && this.params[`${endpoint}_no_context_takeover`]) {
this._deflate.close();
this._deflate = null;
Expand Down