Skip to content

feat(server): add WEBPACK_DEV_SERVER env variable #1929

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
May 27, 2019
Merged

feat(server): add WEBPACK_DEV_SERVER env variable #1929

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions lib/Server.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -62,6 +62,10 @@ if (semver.satisfies(process.version, '8.6.0 - 9')) {
tls.DEFAULT_ECDH_CURVE = 'auto';
}

if (!process.env.WEBPACK_DEV_SERVER) {
process.env.WEBPACK_DEV_SERVER = true;
}

class Server {
constructor(compiler, options = {}, _log) {
if (options.lazy && !options.filename) {
Expand Down
26 changes: 26 additions & 0 deletions test/Server.test.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -474,4 +474,30 @@ describe('Server', () => {
afterAll(testServer.close);
});
});

describe('WEBPACK_DEV_SERVER environment variable', () => {
const OLD_ENV = process.env;

beforeEach(() => {
// this is important - it clears the cache
jest.resetModules();

process.env = { ...OLD_ENV };

delete process.env.WEBPACK_DEV_SERVER;
});

afterEach(() => {
process.env = OLD_ENV;
});

it('should be present', () => {
expect(process.env.WEBPACK_DEV_SERVER).toBeUndefined();

// eslint-disable-next-line global-require
require('../lib/Server');

expect(process.env.WEBPACK_DEV_SERVER).toBe(true);
});
});
});