Skip to content

feat(server): add WEBPACK_DEV_SERVER env variable #1929

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
May 27, 2019
Merged

feat(server): add WEBPACK_DEV_SERVER env variable #1929

merged 1 commit into from
May 27, 2019

Conversation

@alexander-akait
Copy link
Member

@alexander-akait alexander-akait commented May 27, 2019

  • This is a bugfix
  • This is a feature
  • This is a code refactor
  • This is a test update
  • This is a docs update
  • This is a metadata update

For Bugs and Features; did you add new tests?

yes

Motivation / Use-Case

fixes #1533
fixes #1532

Breaking Changes

No

Additional Info

No

@alexander-akait alexander-akait requested a review from hiroppy as a code owner May 27, 2019 15:20
@codecov
Copy link

codecov bot commented May 27, 2019 •
edited
Loading

Codecov Report

Merging #1929 into master will increase coverage by 0.02%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1929      +/-   ##
==========================================
+ Coverage   87.96%   87.99%   +0.02%     
==========================================
  Files          15       15              
  Lines         814      816       +2     
  Branches      259      260       +1     
==========================================
+ Hits          716      718       +2     
  Misses         84       84              
  Partials       14       14
Impacted Files Coverage Δ
lib/Server.js 85.96% <100%> (+0.06%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4b097e2...7ee869e. Read the comment docs.

anshumanv
anshumanv approved these changes May 27, 2019
View reviewed changes
Copy link
Member

@anshumanv anshumanv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Super neat

hiroppy
hiroppy approved these changes May 27, 2019
View reviewed changes
Copy link
Member

@hiroppy hiroppy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@hiroppy hiroppy merged commit 856169e into master May 27, 2019
@hiroppy hiroppy deleted the issue-1533 branch May 27, 2019 19:42
@snyk-bot snyk-bot mentioned this pull request Aug 30, 2019
Closed
@snyk-bot snyk-bot mentioned this pull request Nov 1, 2019
Open
This was referenced Dec 14, 2019
Open
Open
@gauravtiwari gauravtiwari mentioned this pull request Jun 17, 2020
Closed
@justin808 justin808 mentioned this pull request Jun 25, 2020
Merged
@justin808 justin808 mentioned this pull request Jun 17, 2021
Closed
@subzero10 subzero10 mentioned this pull request Nov 10, 2021
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@hiroppy hiroppy hiroppy approved these changes

@anshumanv anshumanv anshumanv approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Set a process.env to see if webpack-dev-server was used

4 participants

@alexander-akait @hiroppy @anshumanv