Refactor/lint dirty modules only #59
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
as opposed to reduce. also use lodash.defaultto for comparing numeric values to avoid falsy JS bugs
and clean up some assertions and specs
Contributor
|
looks good to me 👍 |
Contributor
Author
|
Are there any other test cases you can think of? |
Contributor
|
actually, can't think of anything else. all cases that I'm aware of are covered |
to enable the recursive flag in mocha.
Contributor
|
@JaKXz, all works fine on my local with and without lintDirtyModulesOnly flag. The unrelated thing, I'm seeing that messages are duplicated when |
Verify that existing behaviour works as expected
1 similar comment
Contributor
Author
|
@sergesemashko would you mind making a new issue for that? I think I have a fix, I'll make a PR in the next few minutes. |
joshwiens
pushed a commit
that referenced
this pull request
Mar 31, 2018
* refactor: use filter on filetimestamps' keys as opposed to reduce. also use lodash.defaultto for comparing numeric values to avoid falsy JS bugs * refactor: use Arrange Act Assert model for tests and clean up some assertions and specs * refactor: pulls out defaultFilesGlob constant * refactor: clean up typos * refactor: use .test.js file suffix to enable the recursive flag in mocha. * refactor: better names for all fixtures * tests: add coverage for without plugin config * tests: update NoErrorsPlugin tests Verify that existing behaviour works as expected * refactor: minor test tweaks * tests: correct test of empty plugin config * tests: remove extra context from lint dirty modules plugin
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@sergesemashko to get a better handle on the code from #53 I took a stab at [some minor nits &] refactoring and staying green :) let me know if there's anything that concerns you.
Thanks!