Skip to content

fix: move webpack to a peer dependency and allow webpack 2 #46

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 6 commits into from
Jan 5, 2017
Merged

fix: move webpack to a peer dependency and allow webpack 2 #46

Changes from 1 commit
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
a4d9ff8
fix: move webpack to a peer dependency and allow webpack 2
mattlewis92 Dec 17, 2016
8789da9
test: test against both webpack 1 and webpack 2
Dec 18, 2016
a13d6ca
Merge with master
Dec 26, 2016
a9d6b2b
chore: use npm install version
Jan 5, 2017
505e306
style: whitespace
JaKXz Jan 5, 2017
cadc39a
style: whitespace
JaKXz Jan 5, 2017
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 5 additions & 4 deletions package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -23,14 +23,14 @@
},
"homepage": "https://github.com/vieron/stylelint-webpack-plugin#readme",
"peerDependencies": {
"stylelint": "^7.0.1"
"stylelint": "^7.0.1",
"webpack": "^2 || ^2.2.0-rc.0 || ^2.1.0-beta.0 || ^1.13.2"
Copy link
Contributor

@JaKXz JaKXz Dec 17, 2016

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'd rather just have ^2.0.0 || ^1.13.2 here... I would think it's better to just "officially" support stable versions. With npm >=3 or yarn you won't get peerDeps installed anyway so you can still choose what version you want.

Copy link
Member Author

@mattlewis92 mattlewis92 Dec 18, 2016

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There are no breaking changes between webpack 1 and webpack 2's API that would affect this plugin, it's very safe to support the beta versions of webpack, and gets rid of the annoying peer dependency warning on install.

Copy link
Contributor

@JaKXz JaKXz Dec 18, 2016

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I see, because the rc and beta versions do not fall under semver technically so they aren't resolved by ^2.0.0? Fair enough.

},
"dependencies": {
"arrify": "^1.0.1",
"chalk": "^1.1.3",
"object-assign": "^4.1.0",
"stylelint": "^7.3.1",
"webpack": "^1.13.2"
"stylelint": "^7.3.1"
},
"devDependencies": {
"chai": "^3.5.0",
Expand All @@ -39,7 +39,8 @@
"memory-fs": "^0.3.0",
"mocha": "^3.1.0",
"nyc": "^8.3.1",
"xo": "^0.16.0"
"xo": "^0.16.0",
"webpack": "^1.13.2"
},
"scripts": {
"pretest": "xo",
Expand Down