fix(index): don't use JSON.stringify() to serialize the cache data (options.cache)
#87
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
joshwiens
approved these changes
Dec 14, 2017
michael-ciniawsky
changed the title
cache option behaviorJSON.stringify() to serialize the cache data (options.cache)
michael-ciniawsky
approved these changes
Dec 14, 2017
|
😱 |
michael-ciniawsky
added
status: Approved
and removed
priority: 2 (urgent)
pr_action: Review
severity: 3 (broken)
labels
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We should avoid using
JSON.stringifybecausedatais buffer and after get from cache we return{type: 'Buffer', data: [...]}and this object don't havelength(because it is now notBufferit is just plain object with properties) -minRationdoesn't work.Other cached package also can contain error. I investigate this right now.