Skip to content

Conversation

@alexander-akait
Copy link
Member

BREAKING CHANGE: filename` is changed, you need to return path with placholders

This PR contains a:

  • bugfix
  • new feature
  • code refactor
  • test update
  • typo fix
  • metadata update

Motivation / Use-Case

to avoid problems with immutable files

Breaking Changes

Yes:

  • filename: Function should return filename with placeholders to avoid problems with immutable files
  • the [dir] placeholder was replaced on the [path] placeholder
  • added [fragment] and [base] placeholders

Additional Info

No

BREAKING CHANGE: filename` is changed, you need to return path with placholders
@codecov
Copy link

codecov bot commented Sep 14, 2020

Codecov Report

Merging #195 into master will increase coverage by 0.02%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #195      +/-   ##
==========================================
+ Coverage   98.75%   98.78%   +0.02%     
==========================================
  Files           4        4              
  Lines         161      164       +3     
  Branches       47       46       -1     
==========================================
+ Hits          159      162       +3     
  Misses          1        1              
  Partials        1        1              
Impacted Files Coverage Δ
src/index.js 98.44% <100.00%> (+0.03%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 9de2a88...5a244b0. Read the comment docs.

@alexander-akait alexander-akait merged commit f2dd71b into master Sep 14, 2020
@alexander-akait alexander-akait deleted the refactor-filename-option branch September 14, 2020 15:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants