Skip to content

Conversation

@spawnia
Copy link
Collaborator

@spawnia spawnia commented Oct 25, 2025

No description provided.

@spawnia spawnia requested a review from ruudk October 25, 2025 09:31
@spawnia
Copy link
Collaborator Author

spawnia commented Oct 25, 2025

After successful review, I plan to make the same change in nuwave/lighthouse#2721.

Copy link
Collaborator

@ruudk ruudk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great!

@ruudk
Copy link
Collaborator

ruudk commented Oct 25, 2025

I also see some projects use this https://github.com/changesets/changesets to automate this further.

@spawnia
Copy link
Collaborator Author

spawnia commented Oct 25, 2025

I have considered using semantic-release, as it is done in https://github.com/mll-lab/php-utils. What do you think about that?

@spawnia spawnia merged commit 8c549d9 into master Oct 25, 2025
18 checks passed
@spawnia spawnia deleted the document-release branch October 25, 2025 09:46
@ruudk
Copy link
Collaborator

ruudk commented Oct 25, 2025

I've seen that too. Since you have experience with that one, let's pick that one. We only need to make sure that we have a CI action to enforce proper PR title.

@ruudk
Copy link
Collaborator

ruudk commented Oct 25, 2025

We use this in one of our internal projects:

      - uses: amannn/action-semantic-pull-request@v4
        env:
          GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }}
        with:
          types: |
            fix
            feat
            chore

https://github.com/amannn/action-semantic-pull-request

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants