Skip to content

Conversation

@itsisak
Copy link
Contributor

@itsisak itsisak commented Nov 9, 2025

Description

A user should not have any admin functionality on their own requests. This should be fixed in backend too as currently only "approve" is not allowed on own requests.

Also just centering content of statuspill.

Result

If you've made visual changes, please check the boxes below and include images showing the changes. Descriptions are appreciated.

  • Changes look good on both light and dark theme.
  • Changes look good with different viewports (mobile, tablet, etc.).
  • Changes look good with slower Internet connections.

Caution

Make sure your images do not contain any real user information.

Screenshot 2025-11-09 at 14 39 30

@itsisak itsisak requested review from a team, ch0rizo and falbru November 9, 2025 13:39
@github-actions github-actions bot added the review-needed Pull requests that need review label Nov 9, 2025
@itsisak itsisak added small-fix Pull requests that fix something small chore Pull requests that does something "boring", yet important, e.g. cleaning up code labels Nov 9, 2025
Copy link
Contributor

@magnusbrecke magnusbrecke left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Contributor

@magnusbrecke magnusbrecke left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Design question: Should it have some background-color of some red/orange color to indicate "you are not allowed"?

@itsisak
Copy link
Contributor Author

itsisak commented Nov 9, 2025

Design question: Should it have some background-color of some red/orange color to indicate "you are not allowed"?

Do you mean to color the text? Or like use a red info box, sort of like on events if you have unanswered surveys?

Imo, i think this looks the most clean and less "intrusive", I even considered just removing the whole admin section in this case, but figured people might be a bit confused as to why it might suddenly dissapear

Copy link
Contributor

@ch0rizo ch0rizo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice you fixed the text also😝

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

chore Pull requests that does something "boring", yet important, e.g. cleaning up code review-needed Pull requests that need review small-fix Pull requests that fix something small

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants