Fix Deno v2 bundler incompatibility in ASN.1 certificate decoding #204
+77
−41
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Deno v2's bundler renames internal ASN.1 class constructors (e.g.,
LocalSimpleStringValueBlock→LocalSimpleStringValueBlock2), breaking certificate parsing that relied onconstructor.namestring matching.Changes
Refactored
decodeValue()inlib/certUtils.jsto use property-based type detection instead of constructor name strings:Before:
After:
Type detection now relies on structural properties that bundlers preserve:
valueDecgetterunusedBits+valueHexpropertiesvaluestring property (checked beforevalueHexsince both exist)valuearray property with explicit wrapper exclusionCI Workflow Update:
Re-enabled
deno task buildin.github/workflows/test.ymlto run the complete Deno build process including bundling and testing against bundled code, validating the fix in CI.Fixes #178
Original prompt
💬 We'd love your input! Share your thoughts on Copilot coding agent in our 2 minute survey.