883933669 #28
Open
883933669 #28
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added suport of Chrome Version 25.0.1323.0 canary
comment "rtc.attachStream(stream, 'you');"
comment the repeated code
This commit adds support for the WebRTC DataChannel API. If available, it sends all chat messages through DataChannel. If not, it falls back to using the websocket.
Addresses comments in webRTC-io#11 (comment)
DataChannel support
Connect WebSocket relative to window.location
variable should be declared
…hashes There is an issue on page load when you have a room hash in the url. You get a url fragment error and the socket connection does not succeed
URL fragment issue
…l for Heroku, CloudBees, cloud9), fallback to 8080
Listing port defined in env variable
Updated webrtc.io.js
…een firefox and chrome to but I have not gotten the media to play back. I dont know why the video is not playing back in the video tag... any one please have a look
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
9 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.