This repository was archived by the owner on Mar 5, 2025. It is now read-only.
Add docs note for Geth v1.9.12 eth_call change
#3467
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
It was identified in #3456 that geth released a breaking change regarding the default value of
fromineth_call.This means that if you're calling
viewmethods that refer to amsg.senderwithout explicitly setting afromaddress in your request options, you may see unexpected behavior.This PR adds some notes to the changelog and documentation about this change.
After some discourse we decided that we should not brush this change under the rug by modifying the behavior of
web3.js, but instead stay consistent with the best practices and recommendations from the node clients.In
web3.js, thefromaddress can be specified on a per-call basis or by setting thedefaultAccountproperty.Closes #3456
Type of change
Checklist:
npm run dtslintwith success and extended the tests and types if necessary.npm run test:unitwith success.npm run test:covand my test cases do cover all lines and branches of the added code.npm run build-alland tested the resulting file/'s fromdistfolder in a browser.CHANGELOG.mdfile in the root folder.