perf: reduce allocation for parsing #7219
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Pointers in rust are
usize. On a 32 bit target, this is 4 bytes and on a 64 bit target, this is 8 bytes.A tuple of a
u32is 4 bytes.DisplayofIdentifierwithto_stringLike how other structs are shadowed in the standard library for performance, we shadowed
Identifierto gain performance of callingto_stringinstead of directly callingdisplay.Calling
displaybasically means callingformat!("{}", xxx). This creates additional allocation for formatters.See also: rust-lang/rust#32586.
Checklist