Skip to content

History limit removes the newest command, not the oldest #34

@RReverser

Description

@RReverser

This:

if (this.entries.length > this.size) {
this.entries.pop(0);
}

should've been using .shift(). Instead, current behaviour keeps pushing one item into the history and immediately popping it back, so that once limit is reached, no history items are stored.

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions