[Feature] Detect solano-ci #9
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
watson
reviewed
Aug 14, 2018
Owner
watson
left a comment
watson
left a comment
There was a problem hiding this comment.
Thanks a lot for making this product better 💯
There's just one small nit that I would like to change (see code review comment), other than that it's all 👍👍👍😃
index.js
Outdated
| env.CI || // Travis CI, CircleCI, Gitlab CI, Appveyor, CodeShip | ||
| env.CONTINUOUS_INTEGRATION || // Travis CI | ||
| env.BUILD_NUMBER || // Jenkins, TeamCity | ||
| env.TDDIUM || // Solano CI |
Owner
There was a problem hiding this comment.
There's no need to add TDDIUM to this list as it's taken care of by exports.name which will be set to Solano CI if the TDDIUM environment variable is present
Collaborator
Author
|
👍 Updated. |
Owner
|
Released in version 1.2.0. Thank you 🙏 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Detect Solano CI
docs here http://docs.solanolabs.com/Setup/tddium-set-environment-variables/