Skip to content

Conversation

@ithinuel
Copy link
Contributor

@ithinuel ithinuel commented Oct 24, 2019

This is to allow building and running wasmi on constrained target such as microcontroller.
This requires the ability to build without std.

@parity-cla-bot
Copy link

It looks like @ithinuel hasn't signed our Contributor License Agreement, yet.

The purpose of a CLA is to ensure that the guardian of a project's outputs has the necessary ownership or grants of rights over all contributions to allow them to distribute under the chosen licence.
Wikipedia

You can read and sign our full Contributor License Agreement at the following URL: https://cla.parity.io

Once you've signed, please reply to this thread with [clabot:check] to prove it.

Many thanks,

Parity Technologies CLA Bot

Copy link
Collaborator

@pepyakin pepyakin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I am not sure what is this PR all about. Can you elaborate a bit?

@ithinuel ithinuel force-pushed the render_constrained_system_friendly branch 4 times, most recently from 9716641 to af82094 Compare October 24, 2019 20:47
@ithinuel
Copy link
Contributor Author

@pepyakin Thanks for your review.
This is to allow building and running wasmi on constrained target such as microcontroller.
This requires the ability to build without std.
I updated the PR's description.

Since your first review I updated the truncation related changes. I removed the dependency on BigRational. It does not break the tests and allows to build with nostd.

@ithinuel
Copy link
Contributor Author

This work is also related to paritytech/parity-wasm#283

- reduce DEFAULT_VALUE_STACK_LIMIT from 1MiB to 16KiB
- reduce DEFAULT_CALL_STACK_LIMIT from 64KiB to 16KiB
@ithinuel ithinuel force-pushed the render_constrained_system_friendly branch from af82094 to 79298ab Compare January 14, 2021 23:16
@ithinuel
Copy link
Contributor Author

Hi there, sorry for the way too long delay since my last update.
I ran some tests and removed the changes that are no longer required (around the float primitives).

@pepyakin
Copy link
Collaborator

Thanks, @ithinuel !

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants