-
Notifications
You must be signed in to change notification settings - Fork 21
feat(refactor): Unify tsup configs, gulp -> tsup
#288
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
tsup configs, gulp -> tsup
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This PR refactors the build setup across multiple packages by replacing Gulp with a unified tsup configuration and simplifying the builder logic.
- Removed legacy
gulpfile.jsin several libraries (observables-connect, hooks, factories) and introduced/updatedtsup.config.tsin hooks, factories, and crypto. - Standardized
tsconfig.json(rootDir: "."), updatedpkg.config.jsonto set"bundler": "tsup"and fix export paths, and bumped package versions and devDependencies. - Simplified the
buildertool by removing explicitbundlerparameters, unifyinggeneratePackageJsonandsimpleBuildsignatures, and dropping Gulp handling.
Reviewed Changes
Copilot reviewed 51 out of 51 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| library/observables-connect/gulpfile.js | Removed outdated Gulp build file; needs replacement build config |
| library/hooks/tsup.config.ts | Added new tsup config for hooks package |
| library/hooks/tsconfig.json | Changed "rootDir" to "." |
| library/hooks/pkg.config.json | Switched bundler to tsup, updated exports and peerDependencies |
| library/hooks/package.json | Bumped version, switched build script to tsup, updated devDependencies |
| library/hooks/gulpfile.js | Removed old Gulp build file |
| library/factories/tsup.config.ts | Added new tsup config for factories package |
| library/factories/tsconfig.json | Changed "rootDir" to "." |
| library/factories/pkg.config.json | Switched bundler to tsup, updated exports and peerDependencies |
| library/factories/package.json | Bumped version, switched build script to tsup, updated devDependencies |
| library/factories/gulpfile.js | Removed old Gulp build file |
| library/extension-assets/package.json | Updated peerDependencies for react |
| library/crypto/tsup.config.ts | Extended crypto tsup config to output both ESM and CJS, enabled sourcemaps |
| library/crypto/tsconfig.json | Changed "rootDir" to "." |
| library/crypto/package.json | Bumped version, simplified build script to tsup |
| builder/src/types.ts | Removed 'gulp' from Bundler type |
| builder/src/index.ts | Dropped explicit bundler argument in simpleBuild calls |
| builder/src/builders/util.ts | Simplified generatePackageJson signature and removed bundler-specific branches |
| builder/src/builders/extension-assets/index.ts | Updated generatePackageJson invocation to match new signature |
| builder/src/builders/common/simpleBuild.ts | Simplified simpleBuild signature, removed bundler parameter |
Comments suppressed due to low confidence (2)
library/observables-connect/gulpfile.js:1
- The Gulp build file was removed but no replacement
tsup.config.tsor updated build script was added for observables-connect, so its build will break. Please introduce atsupconfig and adjust itspackage.jsonaccordingly.
-/* @license Copyright 2024 w3ux authors & contributors
library/extension-assets/package.json:30
- There is no
buildscript defined here, butsimpleBuildinvokespnpm buildand will fail. Please add abuildscript (e.g., usingtsupor a copy step) or update the builder to skip the build step for this package.
"compile": "builder -t extension-assets"
This PR refactors the build setup across multiple packages by replacing Gulp with a unified
tsupconfiguration and simplifying the builder logic.gulpfile.jsin several libraries (observables-connect, hooks, factories) and introduced/updatedtsup.config.tsin hooks, factories, and crypto.tsconfig.json(rootDir: "."), updatedpkg.config.jsonto set"bundler": "tsup"and fix export paths, and bumped package versions and devDependencies.buildertool by removing explicitbundlerparameters, unifyinggeneratePackageJsonandsimpleBuildsignatures, and dropping Gulp handling.