Skip to content

Conversation

@rossbulat
Copy link
Contributor

@rossbulat rossbulat commented Jun 11, 2025

This PR refactors the build setup across multiple packages by replacing Gulp with a unified tsup configuration and simplifying the builder logic.

  • Removed legacy gulpfile.js in several libraries (observables-connect, hooks, factories) and introduced/updated tsup.config.ts in hooks, factories, and crypto.
  • Standardized tsconfig.json (rootDir: "."), updated pkg.config.json to set "bundler": "tsup" and fix export paths, and bumped package versions and devDependencies.
  • Simplified the builder tool by removing explicit bundler parameters, unifying generatePackageJson and simpleBuild signatures, and dropping Gulp handling.

@rossbulat rossbulat marked this pull request as ready for review June 11, 2025 10:27
@rossbulat rossbulat changed the title feat(refactor): Unify tsup configs, gulp -> tsup feat(refactor): Unify tsup configs, gulp -> tsup Jun 11, 2025
@rossbulat rossbulat requested a review from Copilot June 11, 2025 10:27

This comment was marked as outdated.

@rossbulat rossbulat requested a review from Copilot June 11, 2025 12:02

This comment was marked as outdated.

@rossbulat rossbulat requested a review from Copilot June 11, 2025 14:19
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR refactors the build setup across multiple packages by replacing Gulp with a unified tsup configuration and simplifying the builder logic.

  • Removed legacy gulpfile.js in several libraries (observables-connect, hooks, factories) and introduced/updated tsup.config.ts in hooks, factories, and crypto.
  • Standardized tsconfig.json (rootDir: "."), updated pkg.config.json to set "bundler": "tsup" and fix export paths, and bumped package versions and devDependencies.
  • Simplified the builder tool by removing explicit bundler parameters, unifying generatePackageJson and simpleBuild signatures, and dropping Gulp handling.

Reviewed Changes

Copilot reviewed 51 out of 51 changed files in this pull request and generated no comments.

Show a summary per file
File Description
library/observables-connect/gulpfile.js Removed outdated Gulp build file; needs replacement build config
library/hooks/tsup.config.ts Added new tsup config for hooks package
library/hooks/tsconfig.json Changed "rootDir" to "."
library/hooks/pkg.config.json Switched bundler to tsup, updated exports and peerDependencies
library/hooks/package.json Bumped version, switched build script to tsup, updated devDependencies
library/hooks/gulpfile.js Removed old Gulp build file
library/factories/tsup.config.ts Added new tsup config for factories package
library/factories/tsconfig.json Changed "rootDir" to "."
library/factories/pkg.config.json Switched bundler to tsup, updated exports and peerDependencies
library/factories/package.json Bumped version, switched build script to tsup, updated devDependencies
library/factories/gulpfile.js Removed old Gulp build file
library/extension-assets/package.json Updated peerDependencies for react
library/crypto/tsup.config.ts Extended crypto tsup config to output both ESM and CJS, enabled sourcemaps
library/crypto/tsconfig.json Changed "rootDir" to "."
library/crypto/package.json Bumped version, simplified build script to tsup
builder/src/types.ts Removed 'gulp' from Bundler type
builder/src/index.ts Dropped explicit bundler argument in simpleBuild calls
builder/src/builders/util.ts Simplified generatePackageJson signature and removed bundler-specific branches
builder/src/builders/extension-assets/index.ts Updated generatePackageJson invocation to match new signature
builder/src/builders/common/simpleBuild.ts Simplified simpleBuild signature, removed bundler parameter
Comments suppressed due to low confidence (2)

library/observables-connect/gulpfile.js:1

  • The Gulp build file was removed but no replacement tsup.config.ts or updated build script was added for observables-connect, so its build will break. Please introduce a tsup config and adjust its package.json accordingly.
-/* @license Copyright 2024 w3ux authors & contributors

library/extension-assets/package.json:30

  • There is no build script defined here, but simpleBuild invokes pnpm build and will fail. Please add a build script (e.g., using tsup or a copy step) or update the builder to skip the build step for this package.
"compile": "builder -t extension-assets"

@rossbulat rossbulat merged commit 6c86e31 into main Jun 11, 2025
3 checks passed
@rossbulat rossbulat mentioned this pull request Jun 11, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants