Fix issue with host-matching and non-ascii hosts #597
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We need to filter out non-ascii hosts before treating them as strings. The note about IPv4/6 addresses can be moved to the top as a result. closes #590
Member
Author
|
@annevk have time to take a look? |
annevk
reviewed
Apr 20, 2023
Member
annevk
left a comment
annevk
left a comment
There was a problem hiding this comment.
Do we have a test that given input %61 or some such it does not match a host that's a? I.e., that this is far more restrictive than the host parser?
Member
Author
Looks like we don't permit URL encoded characters in the host https://chromium-review.googlesource.com/c/chromium/src/+/4454670 |
chromium-wpt-export-bot
pushed a commit
to web-platform-tests/wpt
that referenced
this pull request
Apr 20, 2023
We don't allow url encoded hosts but do permit ports with leading 0s. w3c/webappsec-csp#597 w3c/webappsec-csp#596 Bug: 1418009 Change-Id: Ie8ddc509b63e1aa9d35d4e2b989df63483bfca6a
chromium-wpt-export-bot
pushed a commit
to web-platform-tests/wpt
that referenced
this pull request
Apr 22, 2023
We don't allow url encoded hosts but do permit ports with leading 0s. w3c/webappsec-csp#597 w3c/webappsec-csp#596 Bug: 1418009 Change-Id: Ie8ddc509b63e1aa9d35d4e2b989df63483bfca6a
chromium-wpt-export-bot
pushed a commit
to web-platform-tests/wpt
that referenced
this pull request
Apr 24, 2023
We don't allow url encoded hosts but do permit ports with leading 0s. w3c/webappsec-csp#597 w3c/webappsec-csp#596 Bug: 1418009 Change-Id: Ie8ddc509b63e1aa9d35d4e2b989df63483bfca6a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4454670 Reviewed-by: Dustin Mitchell <[email protected]> Commit-Queue: Ari Chivukula <[email protected]> Cr-Commit-Position: refs/heads/main@{#1134816}
chromium-wpt-export-bot
pushed a commit
to web-platform-tests/wpt
that referenced
this pull request
Apr 24, 2023
We don't allow url encoded hosts but do permit ports with leading 0s. w3c/webappsec-csp#597 w3c/webappsec-csp#596 Bug: 1418009 Change-Id: Ie8ddc509b63e1aa9d35d4e2b989df63483bfca6a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4454670 Reviewed-by: Dustin Mitchell <[email protected]> Commit-Queue: Ari Chivukula <[email protected]> Cr-Commit-Position: refs/heads/main@{#1134816}
annevk
reviewed
Apr 27, 2023
Co-authored-by: Anne van Kesteren <[email protected]>
Co-authored-by: Anne van Kesteren <[email protected]>
antosart
reviewed
Apr 27, 2023
antosart
reviewed
Apr 27, 2023
annevk
reviewed
Apr 27, 2023
github-actions bot
added a commit
that referenced
this pull request
Apr 28, 2023
SHA: 71c967b Reason: push, by arichiv Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Member
|
Indeed, thanks @arichiv! |
moz-v2v-gh
pushed a commit
to mozilla/gecko-dev
that referenced
this pull request
May 22, 2023
…stonly Automatic update from web-platform-tests [CSP] WPTs for matching edge cases We don't allow url encoded hosts but do permit ports with leading 0s. w3c/webappsec-csp#597 w3c/webappsec-csp#596 Bug: 1418009 Change-Id: Ie8ddc509b63e1aa9d35d4e2b989df63483bfca6a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4454670 Reviewed-by: Dustin Mitchell <[email protected]> Commit-Queue: Ari Chivukula <[email protected]> Cr-Commit-Position: refs/heads/main@{#1134816} -- wpt-commits: 4f8df7ab83ab1562214fcca2f67bb1718cc28808 wpt-pr: 39631
jwidar
pushed a commit
to jwidar/LatencyZeroGithub
that referenced
this pull request
Sep 16, 2025
…stonly Automatic update from web-platform-tests [CSP] WPTs for matching edge cases We don't allow url encoded hosts but do permit ports with leading 0s. w3c/webappsec-csp#597 w3c/webappsec-csp#596 Bug: 1418009 Change-Id: Ie8ddc509b63e1aa9d35d4e2b989df63483bfca6a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4454670 Reviewed-by: Dustin Mitchell <[email protected]> Commit-Queue: Ari Chivukula <[email protected]> Cr-Commit-Position: refs/heads/main@{#1134816} -- wpt-commits: 4f8df7ab83ab1562214fcca2f67bb1718cc28808 wpt-pr: 39631
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We need to filter out non-ascii hosts before treating them as strings. The note about IPv4/6 addresses can be moved to the top as a result.
closes #590